-
Notifications
You must be signed in to change notification settings - Fork 2
Closed
Labels
testsRelating to our pytest suiteRelating to our pytest suitetsmSpecific to TSM moduleSpecific to TSM module
Description
This can be closed once we are confident in the calculations being done by the refactored TSM model.
The testing code may need to be updated to work with the refactored pattern.
Tasks:
- Right now
xarray.apply_ufuncis not working with Reynold Number calculation (which contains if/else). This needs to be resolved before this issue can be solved. -> solved w/ Update all if/else functions using the new logic #39 - Double check that the
TSM Manual Checks_1D timestep.xlsxconstant / input values match our defaults. Even if they do, since defaults might change, we should hard code this into the test suite. - Create a test for every case in the XLSX file, instantiate a fresh model and run each time.
- Assess if there are calculation issues, if so, try to diagnose them.
Metadata
Metadata
Assignees
Labels
testsRelating to our pytest suiteRelating to our pytest suitetsmSpecific to TSM moduleSpecific to TSM module