Skip to content

Move TSM calculation tests to the pytest directory -> get them passing #20

@xaviernogueira

Description

@xaviernogueira

This can be closed once we are confident in the calculations being done by the refactored TSM model.
The testing code may need to be updated to work with the refactored pattern.

Tasks:

  • Right now xarray.apply_ufunc is not working with Reynold Number calculation (which contains if/else). This needs to be resolved before this issue can be solved. -> solved w/ Update all if/else functions using the new logic #39
  • Double check that the TSM Manual Checks_1D timestep.xlsx constant / input values match our defaults. Even if they do, since defaults might change, we should hard code this into the test suite.
  • Create a test for every case in the XLSX file, instantiate a fresh model and run each time.
  • Assess if there are calculation issues, if so, try to diagnose them.

Metadata

Metadata

Assignees

No one assigned

    Labels

    testsRelating to our pytest suitetsmSpecific to TSM module

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions