Converting to PyTest (work in progress) #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@xaviernogueira, thanks! |
aufdenkampe
reviewed
Aug 28, 2023
Member
There was a problem hiding this comment.
@xaviernogueira, although the Fortran version was labeled as v1.0, we do not want this Python software to be 1.0.
Rather the first version should be v0.1.0. to follow the conventions from semantic versioning.
If we released this with a v1.0 we would be promising not changes to backward compatibility until a v2.0 release. But version 0.x releases are exempt from that rule.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following tests are in pytest format:
The NSM tests are in the test directory as they should be, but have not been converted yet. Since we will be refactoring TSM/GSM first, I figured we can avoid repeat work by refactoring the NSM tests only once we make final model architecture decisions.
Some other small things are changed. Please merge so I can refactor TSM next.