TSM Refactor stage 1: Numba equations, constants, and pyproject #15
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
pyproject.tomlfile that works and allows the modules to be installed viapip install ./testsshould be passing or in active development (currently empty).environment.ymlfile to includepytestandpyright, which is what I am using for static analysis.Note that I implemented the model in another branch
XRN_xarray_simlab. There I am exploring refactor design options (see below).Next steps:
tsm/equations.py. I will loop back to this once figure out the architecture for xarray-simlab, but regardless we will need these functions JITed as I plan on usingxarray.apply_ufunc(parallelize=True)where the numba functions are applied across xarray dataarrays.xarray-simlab. As I look closer, it is worth using the framework, as the idea I had to work with xarray without it is largely similar.