Improved demo notebook to show a walk-thru on how to **write** a Model/Variables #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xaviernogueira
added
the
documentation
xaviernogueira
deleted the
21-make-a-better-demo-of-the-new-architecture-jupyter-notebook
branch
Member
|
@xaviernogueira, thanks for these updates! I'm sure @kewalak, @imscw95, @sjordan29 and others will appreciate the clearer guidance. I'm glad to see that you implemented a I'll try to review the notebook soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #21
Changes:
model_architecture.ipynbnotebook to step by step walk-thru building a simple model. Only after everything is explained do I show the real-world TSM example.utils.pyto fix a bug.base.Model->base.Model.get_state_variables()that allows state variables to be seen before the model is initialized. This allows one to see which variables need to be put in the input dictionary without digging thru the code.@aufdenkampe mind commenting on the notebook before I merge? (edit: whoops, couldn't revert, still would appreciate comments I can add)