Skip to content

Conversation

@xaviernogueira
Copy link
Contributor

@xaviernogueira xaviernogueira commented Dec 8, 2023

Closes #45

@jrutyna @sjordan29 @aufdenkampe @kewalak @imscw95

use_sed_temp is now implemented! For TSM you can simply pass in use_sed_temp=False to EnergyBudget().

I also added test coverage for it, both a unit test to make sure the boolean logic works, and a calculations test based on the Excel file.

Unrelated: I also adjusted codecov.yml to not "fail" PRs over line-based coverage on added code. I kept the one that expects coverage to stay the same or increase overall. This is because lines can be identified as missed erroneously for small patches, especially with PEP8 formatting.

@xaviernogueira xaviernogueira added enhancement New feature or request tsm Specific to TSM module labels Dec 8, 2023
@xaviernogueira xaviernogueira self-assigned this Dec 8, 2023
@xaviernogueira xaviernogueira linked an issue Dec 8, 2023 that may be closed by this pull request
@EcohydrologyTeam EcohydrologyTeam deleted a comment from codecov bot Dec 8, 2023
@EcohydrologyTeam EcohydrologyTeam deleted a comment from codecov bot Dec 8, 2023
@codecov
Copy link

codecov bot commented Dec 8, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (b1c9997) 38.53% compared to head (d26244f) 38.58%.
Report is 3 commits behind head on main.

Files Patch % Lines
src/clearwater_modules/tsm/processes.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #59      +/-   ##
==========================================
+ Coverage   38.53%   38.58%   +0.05%     
==========================================
  Files          33       33              
  Lines        1160     1161       +1     
==========================================
+ Hits          447      448       +1     
  Misses        713      713              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xaviernogueira xaviernogueira merged commit 999e82d into main Dec 8, 2023
@xaviernogueira xaviernogueira deleted the 45-implement-use_sed_temp-option-for-tsm branch December 8, 2023 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request tsm Specific to TSM module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement use_sed_temp option for TSM

2 participants