This repository was archived by the owner on Apr 4, 2023. It is now read-only.
Fixing Camera Stretch #1365
Merged
Fixing Camera Stretch #1365
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@murillobrand This seems to work really well, thanks a lot! I currently run into issues on Android because of the SDK bumps in #1364 so I can't release the new version yet. But I aim to do it one of these days. |
EddyVerbruggen
added a commit
that referenced
this pull request
Aug 27, 2019
Fixing Camera Stretch #1365
|
FYI In 9.1.1 I'm updating this logic a little to make sure the entire viewport is covered by the camera view, because IMO it looks better than cropping the image. |
|
No problem. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should solve the problem described at #720
Tested on Android 9