Add FCM HTTP V1 service #171

dragermrb · 2024-02-29T13:45:58Z

Add service to use FCM HTTP v1 API.

According to Google (https://firebase.google.com/docs/cloud-messaging/migrate-v1)

Apps using the deprecated FCM legacy APIs for HTTP and XMPP should migrate to the HTTP v1 API at the earliest opportunity. Sending messages (including upstream messages) with those APIs was deprecated on June 20, 2023, and will be removed in June 2024.

shaffe-fr · 2024-06-12T12:34:45Z

Hi,
It looks like new message format is not yet implemented. Is it planned?

matiss-zalans · 2024-06-20T12:08:49Z

@dragermrb Thanks for the solution. We are using your fork. Just wanted to leave a comment here. I know that main project does not allow to use multiple fcm api keys with config structure, but that can be dealt with by using ->setApiKey() . Here I had a bit of a headache. When initializing FcmV1 with default configs or setting projectId the url property was updated. I was using ->setConfig() to set everything at once, that property was not updated. So just a feedback. You could add a check to update url property after setting the whole config. Was trying to find ->setUrl(), but class didn't have that, but PushService::class had that so I had to contruct the full url the same way as in your class. So another feedback. You could override ->setUrl() with project-id injection or something like that where users pass can project-id and code itself could use when reading from config or calling ->setProjectId().

dragermrb · 2024-06-20T13:23:26Z

Hi @matiss-zalans

I have overwritten setConfig() method to updates the URL

pushpak1300 · 2024-07-15T07:52:36Z

Any plans to merge this ?

hossamadelelsayed · 2024-07-16T08:55:21Z

is this PR will be merged soon ?

pultho · 2024-08-13T21:41:00Z

Hi thanks for your contribution here. I will have a look at this next weeks and will prepare a release for that.

AbdulRahmanIqbal · 2024-09-10T19:15:27Z

how much time it will take to fix?

adrianpaiva1 · 2024-09-16T22:54:54Z

@dragermrb I think you need to update your FCMV1Channel class to include the buildData method, your code currently doesn't work when using the FCM Channel in Laravel Notifications. The google API returns errors for the request keys that are no longer valid (sound, color, etc)

this is my custom channel class that works for me

dragermrb · 2024-09-17T06:37:04Z

Hi @adrianpaiva1

Class Edujugon\PushNotification\Channels\FcmV1Channel inherits from Edujugon\PushNotification\Channels\GcmChannel, and it already implements buildData()

adrianpaiva1 · 2024-09-17T16:24:55Z

hi @dragermrb yes but because the buildData method there is including the 'sound' and 'color' fields in the request the Google API is returning an error as they aren't supported anymore I believe.

I'll post the error response from the API later today.

adrianpaiva1 · 2024-09-17T16:31:01Z

dragermrb · 2024-09-17T16:50:17Z

Hi @adrianpaiva1

All these keys al valid according to documentation: https://firebase.google.com/docs/reference/fcm/rest/v1/projects.messages?hl=es#AndroidNotification

adrianpaiva1 · 2024-09-17T19:44:34Z

@dragermrb it looks like those keys are only valid in the 'android' key of the request though, currently it's including them in the base notification object so it's giving that error

https://firebase.google.com/docs/reference/fcm/rest/v1/projects.messages?hl=en#Notification

dragermrb · 2024-09-18T09:32:23Z

Hi @adrianpaiva1

The problem only occurs when using Laravel notifications. Since I don't use them I couldn't reproduce the problem.

I need to do some work to correctly generate the payload from an instance of Edujugon\PushNotification\Messages\PushMessage

I'll post the changes when I have a chance.

adrianpaiva1 · 2024-09-19T13:57:41Z

Thanks @dragermrb one other thing I noticed was the status codes here. I think this should only be a 404 status code.

I was using the unregistedDeviceTokens to remove any invalid tokens for my users and including the 400 status code here means that if I send any invalid request parameters my tokens will be deactivated even if they are valid. From the docs it looks like 404 is correct to me for detecting deactivated device tokens.

pultho

Any chance we can add a test using mocks for basic coverage?

pultho · 2025-05-18T17:21:17Z

src/Config/config.php

+        'priority' => 'normal',
+        'dry_run' => false,
+        'projectId' => 'my-project-id',
+        'jsonFile' => __DIR__ . '/fcmCertificates/file.json',


Use storage_path() instead of __DIR__ to follow Laravel standards.

Maybe apn config needs that change too...

It does, yes.

It's up to you to modify it in the main branch for both drivers.

pultho · 2025-05-18T17:23:18Z

src/FcmV1.php

+
+    protected function getOauthToken()
+    {
+        return Cache::remember(


Lets add Cache::driver(config(...)) so people can configure a cache driver of their choice (depending on their setups). Variable for cache duration should be named more specific about what's actually be cached. Also duration should be moved into the config so people can adjust.

Did you mean Cache::store(config(...))?

Fixed 01da9cc

pultho · 2025-05-18T17:24:06Z

src/FcmV1.php

+    {
+        $this->config = $this->initializeConfig('fcmv1');
+
+        $this->url = 'https://fcm.googleapis.com/v1/projects/' . $this->config['projectId'] . '/messages:send';


Base URL should be changed to constant.

Fixed 0e9d756

dragermrb · 2025-05-19T15:05:38Z

composer.json

@@ -25,8 +25,8 @@
    "require": {
        "php": "^7.1.3 || ^8.0",
        "guzzlehttp/guzzle": "^6.3 || ^7.0.1",
-        "illuminate/support": "~5.8 || ^6.0 || ^7.0 || ^8.0 || ^9.0 || ^10.0 || ^11.0",
-        "illuminate/notifications": "~5.8 || ^6.0 || ^7.0 || ^8.0 || ^9.0 || ^10.0 || ^11.0",
+        "illuminate/support": "~5.8 || ^6.0 || ^7.0 || ^8.0 || ^9.0|^10.0|^11.0|^12.0",


Single pipe are deprecated. Only for backwards compatibility

dragermrb · 2025-05-19T15:31:27Z

Any chance we can add a test using mocks for basic coverage?

In my opinion, the entire test suite needs a major rewrite. I believe such changes are beyond the scope of this PR.

pultho · 2025-05-19T15:34:33Z

In my opinion, the entire test suite needs a major rewrite. I believe such changes are beyond the scope of this PR.

It definitely needs that. But yes, would be out of scope. But would be good to have at least basic coverage on that one here.

dragermrb added 6 commits February 29, 2024 14:42

Add FCM HTTP V1 service

91522a0

Improve error management and unregistered devices tokens

e91253c

Fix dependencies

7687053

Add concurrent request to FcmV1

36b291c

Fix class name

ce21c0b

Handle 404 FCM responses

58fa9bb

shaffe-fr mentioned this pull request Jun 12, 2024

Migrating from legacy FCM to HTTP v1 #173

Open

dragermrb added 2 commits June 20, 2024 15:16

Auto update url after setConfig()

7e2dcfc

Laravel 11 support

b6a55e7

r4y7s mentioned this pull request Sep 5, 2024

notifications not sendings #174

Open

dragermrb added 2 commits September 23, 2024 09:09

Fix Laravel notification payload generation

369f6eb

Handle 400 FCM responses

bd04ab9

pultho requested review from Edujugon and pultho May 18, 2025 17:16

pultho self-assigned this May 18, 2025

pultho added the enhancement label May 18, 2025

Merge branch 'master' into fcm-v1

d4a15b1

pultho requested changes May 18, 2025

View reviewed changes

dragermrb commented May 19, 2025

View reviewed changes

dragermrb added 2 commits May 19, 2025 17:52

Add cache store and duration to config.

01da9cc

Add base url constant.

0e9d756

Add FCM HTTP V1 service #171

Are you sure you want to change the base?

Add FCM HTTP V1 service #171

Uh oh!

Conversation

dragermrb commented Feb 29, 2024

Uh oh!

shaffe-fr commented Jun 12, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

matiss-zalans commented Jun 20, 2024

Uh oh!

dragermrb commented Jun 20, 2024

Uh oh!

pushpak1300 commented Jul 15, 2024

Uh oh!

hossamadelelsayed commented Jul 16, 2024

Uh oh!

pultho commented Aug 13, 2024

Uh oh!

AbdulRahmanIqbal commented Sep 10, 2024

Uh oh!

adrianpaiva1 commented Sep 16, 2024

Uh oh!

dragermrb commented Sep 17, 2024

Uh oh!

adrianpaiva1 commented Sep 17, 2024

Uh oh!

adrianpaiva1 commented Sep 17, 2024

Uh oh!

dragermrb commented Sep 17, 2024

Uh oh!

adrianpaiva1 commented Sep 17, 2024

Uh oh!

dragermrb commented Sep 18, 2024

Uh oh!

adrianpaiva1 commented Sep 19, 2024

Uh oh!

pultho left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dragermrb commented May 19, 2025

Uh oh!

pultho commented May 19, 2025

Uh oh!

Uh oh!

shaffe-fr commented Jun 12, 2024 •

edited

Loading