[0.17] QA: Use resgtest2 chain instead of regtest for rpc tests #432
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtimon
force-pushed
the
e17-new-testchain
branch
from
6a97ac3 to
f0262d7
Compare
jtimon
changed the title
jtimon
force-pushed
the
e17-new-testchain
branch
4 times, most recently
from
0f21093 to
f9d40fc
Compare
|
Now the -extended tests seem to pass |
jtimon
force-pushed
the
e17-new-testchain
branch
4 times, most recently
from
798be6b to
fbf691d
Compare
jtimon
changed the title
3 tasks
jtimon
force-pushed
the
e17-new-testchain
branch
from
fbf691d to
97c3aaa
Compare
|
The motivation for this is to test the testchains feature? |
30 tasks
|
It's to be able to create custom testchains like we do in elements-0.14, it also adapts the tests to run with -chain=regtest2, which implies a different genesis block which doesn't satisfy pow. |
|
Do you want to merge this right away, or wait for final feedback of upstream? LGTM at least! |
|
Actually that's a good question, while feedback is coming fast in bitcoin core, it seems sensible to keep them as similar as possible and wait here. On the other hand, the bitcoin PR could take too long to get merged or not even get merged, so we don't want to wait forever. So, not sure. |
|
Perhaps we should just set a deadline and merge by then? This is kind of blocking follow-up PRs. |
jtimon
force-pushed
the
e17-new-testchain
branch
from
97c3aaa to
ef657ad
Compare
...for unkown chains
...reads params from regular arguments
jtimon
force-pushed
the
e17-new-testchain
branch
from
ef657ad to
a1e0c56
Compare
|
ACK if we want to merge it now! |
instagibbs
added a commit
that referenced
this pull request
Oct 16, 2018
… tests a1e0c56 QA: Use resgtest2 chain instead of regtest for rpc tests (Jorge Timón) 4454c52 QA: Adapt BitcoinTestFramework for chains other than "regtest" (Jorge Timón) a06be15 Testchains: Introduce custom chain whose constructor... (Jorge Timón) 46749eb Testchains: Qt: Simplify network/chain styles and add a default purple (Jorge Timón) c0c1e38 Testchains: Generic selection with -chain=<str> in addition of -testnet and -regtest (Jorge Timón) 56515c3 9102: Really don't validate genesis block (Gregory Sanders) Pull request description: Backport of bitcoin/bitcoin#8994 The tests seem to pass with: ``` python3 ./test/functional/test_runner.py -j4 --extended ``` Let's please try to keep all general review things on bitcoin/bitcoin#8994 and elements-specific things here. Dependencies: - [x] [0.17] Don't edit Chainparams after initialization #427 - [x] [0.17] Test: Fix example_test.py #434 Tree-SHA512: e216587b6f9d3a462372915e01c8eb3c65a61e4ea29f398e65a7fc03a3ea5676c4711527b5cc2c115893591e7cd5b0ecd2f1fac4faf7ef747a022e2657bc99d4
delta1
pushed a commit
to delta1/elements
that referenced
this pull request
Apr 28, 2023
…from coin selection 10c6929 Include vout when copying transaction ID from coin selection (Samuel Dobson) Pull request description: Fixes ElementsProject#432 I think it makes sense to just add the vout to the existing function because I can't imagine a situation where a user in the coin selection dialog would want just the transaction ID rather than the specific outpoint, and they can just delete it from the end anyway. ACKs for top commit: kristapsk: ACK 10c6929 hebasto: ACK 10c6929, tested on Linux Mint 20.2 (Qt 5.12.8). shaavan: ACK 10c6929 Tree-SHA512: df4d132b6c2fd0b590594e91cf54f82c6c0f77ee9ca06296fb726bc3c52b9ae459ca3b50c48b2bf303ccafe832b6b4dba692a812f439991ca6d807ea0d8df934
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of bitcoin/bitcoin#8994
The tests seem to pass with:
Let's please try to keep all general review things on bitcoin/bitcoin#8994 and elements-specific things here.
Dependencies: