[0.17] Full RBF support #481
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
30 tasks
|
rebased |
luke-jr
approved these changes
Dec 18, 2018
| @@ -276,6 +276,8 @@ enum ServiceFlags : uint64_t { | |||
| // collisions and other cases where nodes may be advertising a service they | |||
| // do not actually support. Other service bits should be allocated via the | |||
| // BIP process. | |||
|
|
|||
| NODE_REPLACE_BY_FEE = (1 << 26), | |||
There was a problem hiding this comment.
I don't think this makes sense if the entire network (or even most of it) will be expected to enable full RBF.
There was a problem hiding this comment.
(Although note that this PR does NOT currently enable full RBF by default...)
There was a problem hiding this comment.
Correct. I wanted something as minimal as possible, such that nodes could opt-out(of honoring non-rbf).
Perhaps this flag is over-kill, but 🤷♂️
instagibbs
added a commit
that referenced
this pull request
Dec 18, 2018
c00d83f Set walletrbf default to 1 (Gregory Sanders) 0853a23 Make it possible to unconditionally RBF with mempoolreplacement=fee,-optin (Luke Dashjr) d0cccad Recognise temporary REPLACE_BY_FEE service bit (Luke Dashjr) Pull request description: Setting `-mempoolreplacement=fee,-optin` will cause the node to honor any RBF replacements even if they had the opt-out flags set. This also sets the default for the wallet to create bip125-signaling transactions. Tree-SHA512: 04ecc010b6255b5346357f831609702a8a33531fb21e83e061b19945b4a83afe2e5bd82b6602e04394871d9f0c074c54847ff4616930bcd2c17f3c3ddd808fae
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting
-mempoolreplacement=fee,-optinwill cause the node to honor any RBF replacements even if they had the opt-out flags set.This also sets the default for the wallet to create bip125-signaling transactions.