-
Notifications
You must be signed in to change notification settings - Fork 250
Add spirv-tools and spirv-tools-sys crates to wrap usage of spirv-tools #179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Splits steps to clearly show how long each part of a longer (eg test) step actually takes * Label all steps
This fixes the docs deployment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces the use of spirv-tools' binaries (as, opt, and val) with the ability use the compiled C++ code instead, or in addition to the spirv binaries.
Additions
spirv-tools-sys
which buildsspirv-tools
, including a small generator script that generates some includes based on spirv-headersspirv-tools-sys/src/c/opt.cpp
which is just a thin (and incomplete) C wrapper around Optimizer because C++spirv-tools
crate which provides a slighly nicer API on top ofspirv-tools-sys
Changes
spirv-opt
binary in link.rs withspirv_tools::opt::Optimizer
spirv-val
for validating resulting binaries in link.rs withspirv_tools::val::Validator
spirv-as
in the linker tests withspirv_tools::as::Assembler
use-installed-tools
anduse-compiled-tools
feature flags, whereuse-compiled-tools
is the default feature for optimal user experience.Missing
Assembler
will choke on hexadecimal floats, but we only use theAssembler
in tests and none of them currently use hexadecimal floats, so figured this would be ok for now, the issue is fixable but doing C++ code was making me sad so I punted until it became an actual issue.Resolves: #31