Unify code in emmylua_check and emmylua_doc_cli #609
+378
−200
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both CLI tools have similar, yet slightly different code and usage. This PR makes them more consistent. In `emmylua_doc_cli`: - added positional parameter `[WORKSPACE]...`; - deprecated `-i, --input` in favor of `[WORKSPACE]...`; - added `-c, --config` to specify location of `.emmyrc.json`/`.luarc.json`; - added `--ignore` to specify ignored files. No short option for `--ignore` because that would clash with `-i, --input`; - deprecated long option `--format` in favor of `--output-format`; - supported `--output stdout` for JSON output; - re-implemented debug output using `log` crate, added `--verbose` option; - contents of `init.rs` are now identical to those from `emmylua_check`. In `emmylua_check`: - added short option `-f` for output format, - supported specifying multiple workspaces.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge this after #608.
Both CLI tools have similar, yet slightly different code and usage. This PR makes them more consistent.
In
emmylua_doc_cli:[WORKSPACE]...;-i, --inputin favor of[WORKSPACE]...;-c, --configto specify location of.emmyrc.json/.luarc.json;--ignoreto specify ignored files. No short option for--ignorebecause that would clash with-i, --input;--formatin favor of--output-format;--output stdoutfor JSON output;logcrate, added--verboseoption;init.rsare now identical to those fromemmylua_check.In
emmylua_check:-ffor output format,