Skip to content

refactored appendTestData #327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Joseph-Jacobson
Copy link

@Joseph-Jacobson Joseph-Jacobson commented May 28, 2025

Description

Requirements

  • XPlat_Utils pull#28

  • Notes for Reviewer

  • This change removes the previous sawtooth logic, replacing it with a function call to "appendTestDataMessage" in EmotiBitPacket which will be building the test packets for EmotiBit.cpp. It is also wrapped in a conditional to check if recording has begun, ensuring our SD card files follow the determined results from EmotiBitPacket

Testing

Results

  • None

Feature Tests

None

Shared files

  • Firmware binary: [Link to firmware binary]
    None
  • Other files.
    None

Checklist to allow merge

  • All dependent repositories used were on branch master
  • Software
    • Get approval from the reviewer
    • Passed testing on Windows
    • Passed testing on macOS (for major changes/GUI changes/ PRs adding files distributed with the EmotiBit software)
    • Passed testing on linux (ubuntu) (for major changes/GUI changes/ PRs adding files distributed with the EmotiBit software)
    • Update software bundle version in ofxEmotiBitVersion.h
  • Firmware
    • Set testingMode to TestingMode::NONE
    • Set const bool DIGITAL_WRITE_DEBUG = false (if set true while testing)
    • Update version in EmotiBit.h
    • Update library.properties to the correct version (should match EmotiBit.h)
  • doxygen style comments included for new code snippets
  • Required documentation updated

Screenshots:

@Joseph-Jacobson Joseph-Jacobson marked this pull request as ready for review May 30, 2025 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant