Fix Java 9 + regression, and layer in mavenization #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey that's pretty dope |
|
It is probably better to submit clear PR with fix only to loftar. |
|
Sounds good. If you've no appetite for maven, I'll maintain that
separately. Thanks for the reply, will provide clean PR shortly.
…On Sat, Apr 3, 2021, 11:18 Andrii Gook ***@***.***> wrote:
It is probably better to submit clear PR with fix only to loftar.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#19 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADD5DR4BXJKXYSOG6QK2PTTG4WVHANCNFSM42DVC3UQ>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let me know if you'd prefer just the Java 9 Buffer fix, but basically if you compile using Java 9 or later (I am compiling using Java 11 locally) the application fails due to a change in Java 9 involving the method return types of various ByteBuffer implementations. See apache/felix#114 for details. This impacts a handful of methods and files, which I've updated as a cherry-pickable commit.
As well, I don't prefer working with Ant by itself, so I've mavenized the project as well. Produces equivalent output to the
targetfolder instead of thebuildfolder, does all equivalent work as the Ant build.xml but via maven. Invoke the parent pom viamvn clean package -f parent-pom.xml. Any non-mavenized resources jars (like loftar's library, and javax.jnlp) are replicated in a local "maven repo" for resolution.I don't know if you're open to outside contribution, or if this represents anything of value for you, but figured I'd attempt the contribute regardless. Have a great day.