Validate fixed PDU lengths and encoded item length overflow#799
Open
atlex00 wants to merge 1 commit into
Open
Conversation
atlex00
force-pushed
the
fix/ul-pdu-length-validation
branch
from
3205ae4 to
5d1e32f
Compare
This comment was marked as resolved.
This comment was marked as resolved.
atlex00
force-pushed
the
fix/ul-pdu-length-validation
branch
from
5d1e32f to
15fd94d
Compare
atlex00
force-pushed
the
fix/ul-pdu-length-validation
branch
from
15fd94d to
056ca0d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
read_pduaccepted the fixed-size A-ASSOCIATE-RJ, A-RELEASE-RQ, A-RELEASE-RP, and A-ABORT PDUs with declared lengths other than 4, silently ignoring trailing bytes. The chunk writers also cast lengths withas u16/as u32, so oversized items could wrap and emit invalid length fields.DICOM PS3.8 fixes these PDU-length fields at
00000004H(§9.3.4, §9.3.6, §9.3.7, §9.3.8) and defines item/PDU length fields as exact lengths. This requirespdu_length == 4for those fixed PDUs on read, replaces the length casts with checked conversions that error on overflow, and adds the corresponding read/write error variants.