Skip to content

PE-1127: enable Windows remote execution #293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .bazelrc
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@ build:remote_windows_x64 --compiler=msvc
build:remote_windows_x64 --action_env=BAZEL_DO_NOT_DETECT_CPP_TOOLCHAIN=1
build:remote_windows_x64 --extra_execution_platforms=//platform/windows_x64
build:remote_windows_x64 --extra_toolchains=//platform/windows_x64:cc-toolchain
build:remote_windows_x64 --enable_runfiles

# Options for private EngFlow clusters.
# To use on your own cluster, change the URLs to your own endpoint.
Expand Down
19 changes: 17 additions & 2 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -62,20 +62,35 @@ jobs:
revision: d04e89854b3931f4aaced77aa3a2fcad5834b3a6
remote_execution: 'true'

- os: windows
arch: x64
os_distribution: server
os_version: "2022"
revision: d04e89854b3931f4aaced77aa3a2fcad5834b3a6
remote_execution: 'true'

steps:
- uses: actions/checkout@v3

- name: Set up authentication
shell: bash
run: cp infra/bazelrc .bazelrc.user

- name: Generate python requirements lock
- name: Generate python requirements lock (bash)
if: matrix.os != 'windows' && success()
shell: bash
run: bazel run //python:requirements.update

# msys2 bash mutates the last argument, removing one of the slashes.
# Use powershell instead, even though it's nearly the same command.
- name: Generate python requirements lock (powershell)
if: matrix.os == 'windows' && success()
shell: powershell
run: bazel run --enable_runfiles //python:requirements.update

- name: Build and test
env:
ARCH: ${{ matrix.arch }}
OS: ${{ matrix.os }}
REMOTE_EXECUTION: ${{ matrix.remote_execution }}
run: python3 infra/test-all.py
run: python infra/test-all.py