Skip to content

feat: default flora additions #2782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

DereC4
Copy link

@DereC4 DereC4 commented Jun 3, 2025

I was thinking of adding the new 1.21.5 flora for temperate generator (bush) and for desert generation, add the dry grass variants since those are confirmed to fit the generator

Also added a check for badlands

referenced #2781 altho now idk ;-;

@DereC4 DereC4 requested a review from a team as a code owner June 3, 2025 07:41
@me4502
Copy link
Member

me4502 commented Jun 3, 2025

Thanks for the PR- as this is a feature addition it should be targeting the master branch.

Re: my comment on the issue- in general PRs to add it are fine, it's more that any major effort doesn't make sense to do. This is a fairly simple PR to add it without any major reworks, so I personally have nothing against it

@DereC4 DereC4 changed the base branch from version/7.3.x to master June 3, 2025 07:46
@DereC4
Copy link
Author

DereC4 commented Jun 3, 2025

whoops let me change that

@DereC4
Copy link
Author

DereC4 commented Jun 3, 2025

Thanks for the PR- as this is a feature addition it should be targeting the master branch.

Re: my comment on the issue- in general PRs to add it are fine, it's more that any major effort doesn't make sense to do. This is a fairly simple PR to add it without any major reworks, so I personally have nothing against it

unrelated but are you the original creator by any chance ?

@wizjany
Copy link
Collaborator

wizjany commented Jun 6, 2025

I don't really think it makes sense to change flora in this way at this point. It was written when there were only two flowers, and updating it properly would be a lot more work than it's worth given feature gen exists now. A partial attempt like this only brings us further from its original state while not really bringing it in line with Minecraft's gen either.

@DereC4
Copy link
Author

DereC4 commented Jun 6, 2025

aw ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants