Add --if-not-exists flag to receive-wal #1065
Conversation
|
I'm antonag32 but ended up doing this outside work hours so I'm using my personal account. Let me know if I have to make any changes. |
|
Added the new flag to the RST docs. |
barman/server.py
Outdated
| args = "Replication slot '%s' already exists", self.config.slot_name | ||
| if ignore_duplicate: | ||
| output.info(*args) | ||
| else: | ||
| output.error(*args) |
There was a problem hiding this comment.
Regarding the output message and how it's being set here. I would prefer a slightly different message when the user accepts the existing slot without failing than when it doesn't.
Also, follow the same process for calling the output module as in other parts of the code, meaning, don't pass a variable where you store the message string, but rather have the string be formatted when calling info() or error() methods.
There was a problem hiding this comment.
Went ahead and changed the message so what happened is more clear to the user. Let me know what you think.
This flag prevents `receive-wal` from exiting with an error when a slot with the same name already exists. This is the same behavior as calling `pg_receivewal` with the same flag. References: EnterpriseDB#1049.
crazybolillo
force-pushed
the
master
branch
2 times, most recently
from
f96db2d to
70102b2
Compare
This flag prevents
receive-walfrom exiting with an error when a slot with the same name already exists. This is the same behavior as callingpg_receivewalwith the same flag.References: #1049.