SDT and pytest dependencies made optional #42
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
wantysal
commented
Mar 1, 2022
wantysal
commented
- requirements.txt and setup.py modified to make SciDataTool and pytest optional, but they still appear in tests_require for the developers
- full_requirements with all the dependencies
- Audio class and methods modified so as to check SciDataTool installation
- tests modified to check pytest installation
…sts_require list)
… from basic requirements
mglesser
requested changes
Mar 1, 2022
There was a problem hiding this comment.
Thanks for this contribution. I've made some small comments. In addition can you please update the main readme.md to describe how to install via pip including SciDataTool. It could be worth mentioning that all dependencies can be installed via pip install mosqito[all]
mglesser
approved these changes
Mar 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.