-
Notifications
You must be signed in to change notification settings - Fork 0
PEP 9999: Add PEP 508 compatibility examples #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PEP 9999: Add PEP 508 compatibility examples #3
Conversation
I think this is best to be merged in once we've decided on the spec, but before the deadline (2020-09-08 19:00-07:00) |
Initial set of examples demonstrating compatibility with PEP 508.
a9e0c8e
to
a68a056
Compare
@EpicWink I have updated the vcs examples and rebased ontop of your branch |
This still has the environment marker keys, but you say in the discourse discussion that you think we should leave out the environment markers for now. I personally think the environment marker keys are good to leave in, possibly with a prefix, but the |
Ah yes, my bad. Making this change is what made me change my mind.
- aiohttp = { version = ">= 3.6.1", markers = "python_version >= '3.8'" }
+ aiohttp = { version = ">= 3.6.1", python-version = ">= '3.8'" }
To me, the "exploded-markers" is an easy addition to what we have already. And right now the use of |
@EpicWink do you want me to add the exploded form as an example as well since you already merged that? |
Yeah, makes sense. Right now we don't have enough time to flesh out any fancy parsing, so it makes sense to add environment marker keys down the line.
I reverted that change. I accidentally merged that in. I've marked it as deferred in the rejected-ideas section. |
I've gone with the |
Fixed. We should mention the futre changes somewhere too eventually I guess. Making sure that it is understood that this is a first step towards better specification. |
Initial set of examples demonstrating compatibility with PEP 508.