Skip to content

PEP 9999: Add PEP 508 compatibility examples #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

abn
Copy link

@abn abn commented Sep 7, 2020

Initial set of examples demonstrating compatibility with PEP 508.

@EpicWink
Copy link
Owner

EpicWink commented Sep 8, 2020

I think this is best to be merged in once we've decided on the spec, but before the deadline (2020-09-08 19:00-07:00)

@abn abn force-pushed the pep-621-exploded-dependencies-add-compatibility branch from a9e0c8e to a68a056 Compare September 9, 2020 00:25
@abn
Copy link
Author

abn commented Sep 9, 2020

@EpicWink I have updated the vcs examples and rebased ontop of your branch

@EpicWink
Copy link
Owner

EpicWink commented Sep 9, 2020

This still has the environment marker keys, but you say in the discourse discussion that you think we should leave out the environment markers for now. I personally think the environment marker keys are good to leave in, possibly with a prefix, but the extra marker will need to be special-cased

@abn
Copy link
Author

abn commented Sep 9, 2020

Ah yes, my bad. Making this change is what made me change my mind.

 
-        aiohttp = { version = ">= 3.6.1", markers = "python_version >= '3.8'" }
+        aiohttp = { version = ">= 3.6.1", python-version = ">= '3.8'" }
 

To me, the "exploded-markers" is an easy addition to what we have already. And right now the use of ">= '3.8'" seems to be like an inefficient use. For example in poetry there exists special parsing that shortens that to ">=3.8".

@abn
Copy link
Author

abn commented Sep 9, 2020

@EpicWink do you want me to add the exploded form as an example as well since you already merged that?

@EpicWink
Copy link
Owner

EpicWink commented Sep 9, 2020

For example in poetry there exists special parsing that shortens that to ">=3.8".

Yeah, makes sense. Right now we don't have enough time to flesh out any fancy parsing, so it makes sense to add environment marker keys down the line.

do you want me to add the exploded form as an example as well since you already merged that?

I reverted that change. I accidentally merged that in. I've marked it as deferred in the rejected-ideas section.

@EpicWink
Copy link
Owner

EpicWink commented Sep 9, 2020

I've gone with the for-extra (instead of for-extras), again to ensure one line per specified requirement

@abn
Copy link
Author

abn commented Sep 9, 2020

Fixed. We should mention the futre changes somewhere too eventually I guess. Making sure that it is understood that this is a first step towards better specification.

@EpicWink EpicWink merged commit febb954 into EpicWink:pep-621-exploded-dependencies Sep 9, 2020
@abn abn deleted the pep-621-exploded-dependencies-add-compatibility branch September 9, 2020 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants