This repository was archived by the owner on Feb 27, 2025. It is now read-only.
[AUDIT][LOW SEVERITY] Fix no-op validation in vote accumulator #3507
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #<ISSUE_NUMBER>
This PR:
When the leader of view is collecting votes to create, for example, a quorum certificate the leader will call
handle_quorum_vote_recveach time it receives a vote, which will then handle the vote sent in until it have a threshold of votes.When the first vote is received, the leader will create a vote accumulator task by calling
create_vote_accumulator.The problem is in the way we validate the first vote's view number. This is done by erroring if
vote.view_number() != info.view. But this validation will not do anything sinceinfo.viewwill be set tovote.view_number().This PR removes the redundant check since every code branch that executes this initializes the
infoview number with the view number from the vote.This PR does not:
Key places to review: