Skip to content
This repository was archived by the owner on Feb 27, 2025. It is now read-only.

Conversation

@jparr721
Copy link
Contributor

Closes #<ISSUE_NUMBER>

This PR:

When the leader of view is collecting votes to create, for example, a quorum certificate the leader will call handle_quorum_vote_recv each time it receives a vote, which will then handle the vote sent in until it have a threshold of votes.

When the first vote is received, the leader will create a vote accumulator task by calling create_vote_accumulator.

The problem is in the way we validate the first vote's view number. This is done by erroring if vote.view_number() != info.view. But this validation will not do anything since info.view will be set to vote.view_number().

let info = AccumulatorInfo {
            public_key: task_state.public_key.clone(),
            membership: Arc::clone(&task_state.quorum_membership),
            view: vote.view_number(),
            id: task_state.id,
        };

This PR removes the redundant check since every code branch that executes this initializes the info view number with the view number from the vote.

This PR does not:

Key places to review:

@jparr721 jparr721 merged commit ee2591d into main Jul 30, 2024
@jparr721 jparr721 deleted the jp/GLOBAL-1 branch July 30, 2024 13:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants