make the registerValidatorV2 contract pausable and add tests #3480
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alysiahuggins
requested review from
sveitser,
jbearer,
imabdulbasit,
ss-es,
pls148,
bfish713,
rob-maron and
lukaszrzasik
as code owners
sveitser
approved these changes
Aug 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #<ISSUE_NUMBER>
This PR:
this pr makes the registerValidatorV2 pausable and adds & updates tests for the pausable functionality in staketablev2. it checks that all functions with whenNotPaused revert when paused, and that unpausable functions remain callable. it also verifies correct event emission and role-based access for pausing and unpausing.
This PR does not:
this pr does not change contract logic
Key places to review:
StakeTableV2StakeTable.t.solHow to test this PR:
Things tested