Cryptovec/Windows: Add reference counting per Page, improve error-msg #471
+91
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
the current CryptoVec implementation on Windows unlocks memory pages too early if the backing stores of multiple CryptoVecs are located in the same page.
This is because VirtualLock/Unlock do not implement reference-counting on the OS side:
This PR adds userspace lock counting, so only once the last CryptoVec has released it's memory from a Page, the Page is unlocked.