fix: allow Stream to connect to multiple addresses
#545
+6
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, when using `config.stream()`, it would resolve the host, port pair and pick the first address returned. But Tokio has built-in support to resolve multiple addresses and connect to each one until one succeeds. So this PR lifts the previous restriction. The main consquence is that the `Error::NotResolvable` is gone since it will be reported as an `Io` error by Tokio instead.
Owner
|
Thank you! |
Owner
|
@all-contributors please add @plaflamme for code |
Contributor
|
I've put up a pull request to add @plaflamme! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when using
config.stream(), it would resolve the host, port pair and pick the first address returned. But Tokio has built-in support to resolve multiple addresses and connect to each one until one succeeds. So this PR lifts the previous restriction.The main consquence is that the
Error::NotResolvableis gone since it will be reported as anIoerror by Tokio instead.