Feat/support android dev ips#75
Merged
Merged
Conversation
Android maps to 10,0.2.2 needs trusting, trusted had docker incrementally assigned ip - removed 🔥. Changed the occ trusted order Signed-off-by: James Manuel <moodyjmz@users.noreply.github.com>
Signed-off-by: James Manuel <moodyjmz@users.noreply.github.com>
Signed-off-by: James Manuel <moodyjmz@users.noreply.github.com>
Member
Author
|
switched back to draft to test more - cache... need to stress test it |
Member
Author
|
ah, it is the IP rotation, so behaving as expected, however I have a little think |
Signed-off-by: James Manuel <moodyjmz@users.noreply.github.com>
Member
Author
|
Switching to draft as I don't like the make local changing. These changes should be independent of that. |
Signed-off-by: James Manuel <moodyjmz@users.noreply.github.com>
Signed-off-by: James Manuel <moodyjmz@users.noreply.github.com>
AndyScherzinger
approved these changes
Apr 21, 2026
mosa-riel
pushed a commit
to mosacloud/eurooffice
that referenced
this pull request
Jun 15, 2026
…id-dev-ips Feat/support android dev ips
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #74
Testing on desktop browsers is fine. Testing on Mac + simulated iPhone is also fine. As is iPhone in Nextcloud App.
However, Android is not fine. Android maps 10.0.2.2 to localhost, this doesn't work.
We have to do two things
Ensure 10.0.2.2 is allowed
Set the DocumentServerUrl to something accessible on the local net as it gets set to the OO iframe
Impl:
2) As we need the actual IP, get this and also introduce a way to keep this updated - when networks change without having to pull docker all down etc - as part of make local this happens, and also adds make refresh to allow quick updates if needed.Made nicer approach usingmake mobile- one time docker update, then it is thereThis way, everything works :)
Testing
Inside DocumentServer/develop:
docker down -v- This is remove existing EO so, you might want to do this on a version you aren't dev'ing on. One time thing.make local- runs as normalmake mobile- uses localhost for desktop, but will also work for Android devices simulated via Android Studio (can use the IP make mobile provides, or 10.0.2.2 - the one Android Studio maps to localhost)Switch between the two to your heart's content. Testing as appropriate.