Repository navigation
fix(test): re-run a CI pass wedged by a lost child exit - #1806
Merged
Merged
Conversation
…ailing at 20 minutes The stall watchdog's process listing showed every recent stalled `test` job as a bun test worker holding a `<defunct>` python3 or git child: bun never took the child's exit, and no per-test or spawnSync timeout frees the worker. The runner now polls for that zombie, and after 60 seconds kills the pass and runs it once more in a fresh process. A stall without the zombie still fails at the 20-minute limit.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Merged
This was referenced Oct 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When a bun test worker loses a child process's exit, CI now notices within about a minute, stops the tests, and runs the suite once more in a fresh process. Before, the job sat for 20 minutes and then failed. That happened on 5 of the 6 red
testruns on 2026-09-29, including release PR #1781.What the stall is
The process listing from #1787's watchdog showed the same thing in every stalled run: one
bun test --test-workerstill alive, its only child a[python3] <defunct>or[git] <defunct>that had exited about 40 seconds into the pass. bun never took that exit, so the worker stayed blocked in thespawnSynccall while every other file finished. The hung file differed per run (doc-claims-validator,ce-babysit-pr-snapshot, andce-work-unit-workspace-fallbackthree times). The workspace harness's own 20sspawnSynctimeout did not fire either, so adding timeouts to test spawns would not help. Only a process outside the worker can recover.Design decisions
CE_TEST_LOST_EXIT_SECONDSoverrides). bun takes a child's exit within milliseconds, so a slow test does not trip it. A zombie under any other process is ignored.Validation
tests/run-tests-script.test.tscreates a real zombie under a process named like a bun test worker. The runner recovers when only the first attempt loses the exit and fails when both do. A parser test checks that a zombie under a non-bun parent is ignored.bun run testpasses locally.Security Disclosure
No security-relevant changes.
Agent Disclosure