Cython3 compatibility #97
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Change __check_compatibility to _check_compatability, as Cython3 mangles names starting with __ in inherited classes like Python - Explicitly declare noexcept in relevant type signatures so that we don't need the legacy_implicit_noexcept directive. - This should still be compatible with Cython <3
This should be in a separate environment - this is mostly to triangulate the CI related failures on macosx. If it does work this is simpler anyway!
Closed
|
Awesome, thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the necessary changes for Cython 3 compatibility, while still working with Cython <3. This PR removes the need to use the
legacy_implicit_noexceptdirective.I've also changed the way wheels are built for the test_wheels tox environment, now using
python -m buildto create them in an isolated environment. This is because I was running into the same test failures on MacOSX as my last PR - I'm not 100% sure if that's even a Cython only problem, or a combination of Cython + Tox + installation things. I'd investigate further into why this works, but I don't have access to an OSX environment. I'd expect most people will be using prebuilt wheels anyway, and the standard local source install test cases work without changes anyway.