Skip to content

Conversation

@its-miroma
Copy link
Member

@its-miroma its-miroma commented Feb 12, 2025

A simple Credits page with a list of GitHub maintainers and contributors, Crowdin translators, and page authors.

  • CROWDIN_TOKEN
  • GITHUB_TOKEN
Name Link
😎 Deploy Preview https://deploy-preview-280--nimble-elf-d9d491.netlify.app/credits

@its-miroma its-miroma added needs-discussion Further discussion is needed framework Related to the VitePress framework todo:expand This should be expanded labels Feb 12, 2025
@netlify

This comment was marked as duplicate.

@its-miroma its-miroma marked this pull request as ready for review February 12, 2025 21:02
@its-miroma its-miroma requested review from a team as code owners February 12, 2025 21:02
@its-miroma its-miroma added todo:verify This needs to be reviewed and removed needs-discussion Further discussion is needed todo:expand This should be expanded labels Feb 12, 2025
@its-miroma its-miroma force-pushed the team branch 2 times, most recently from ee79215 to c4bc67b Compare February 15, 2025 18:26
Copy link
Member

@modmuss50 modmuss50 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error handling needs fixing.

I do worry this docs site is becoming very complex now, I guess its fine.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this still needs testing as I don't have a Crowdin token

Comment on lines +83 to +101
<VPTeamPageSection v-if="committers.length">
<template #title>{{ options!.committers.title }}</template>
<template #members>
<VPTeamMembers :members="committers" size="small" />
</template>
</VPTeamPageSection>
<VPTeamPageSection v-if="authors.length">
<template #title>{{ options!.authors.title }}</template>
<template #members>
<VPTeamMembers :members="authors" size="small" />
</template>
</VPTeamPageSection>
<VPTeamPageSection v-if="translators.length">
<template #title>{{ options!.translators.title }}</template>
<template #members>
<VPTeamMembers :members="translators" size="small" />
</template>
</VPTeamPageSection>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how do you prefer these to be sorted?

Copy link
Member

@IMB11 IMB11 Nov 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would probs split this up into github and crowdin

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also this page is only accessible by URL

@its-miroma its-miroma force-pushed the team branch 3 times, most recently from 198455c to a6ccb33 Compare March 12, 2025 09:54
@its-miroma its-miroma added the priority:low This is nice to have, but it can wait a little label May 2, 2025
@its-miroma its-miroma marked this pull request as draft September 10, 2025 06:43
@its-miroma its-miroma removed the priority:low This is nice to have, but it can wait a little label Sep 17, 2025
@its-miroma its-miroma added the priority:low This is nice to have, but it can wait a little label Oct 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

framework Related to the VitePress framework priority:low This is nice to have, but it can wait a little todo:verify This needs to be reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants