Add way to get an instance of WorldRenderContext if you only have a WorldRenderer #4709
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cputnam-a11y
approved these changes
Jun 16, 2025
modmuss50
added
status: last call
modmuss50
pushed a commit
that referenced
this pull request
Jun 23, 2025
(cherry picked from commit a7b184c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is especially useful if a mod wants to create their own custom render event, but could also be useful more generally in case someone wants to access stuff from this context but doesn't have direct access to that context for some reason.
Note that even in situations where you don't strictly require a
WorldRenderContext, it can still be useful to have one as it captures local variables from insideWorldRendererwhich are otherwise difficult to access.