Add lava chicken music disk to music disks tag. #4722
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Couldn't it be added as optional? |
Member
Author
I tried with |
Member
|
Maybe using this.builder(ConventionalItemTags.MUSIC_DISCS).addOptional(Registries.ITEM.getKey(Items.MUSIC_DISC_LAVA_CHICKEN)) in seperate line? |
Member
Author
Same thing, looks like there is a bug somewhere.... |
modmuss50
added
the
status: merge me please
Member
Author
|
Going to merge this, there might be a bug here that is worth looking into. Thinking about it im not too keen on having to make code changes to support older versions, I dont think many people will care about .6 for long so its not a big loss. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also means we arent backwards compatible with 1.21.6, not the end of the world.