Fix getRecipeIdentifier applying twice to advancement paths #4725
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a bug introduced in FabricMC#4703. The advancement's path is already modified by the getRecipeIdentifier call in each recipe JSON builder mixin, so this applied getRecipeIdentifier twice to a single ID (and to different parts). For example, this getRecipeIdentifier implementation: return super.getRecipeIdentifier(identifier).withPrefixedPath("foo/"); would have resulted in an advancement being placed at data/mod_id/advancements/foo/recipes/.../foo/the_item.json, which is clearly wrong. With this fix, only the last "foo/" will appear.
modmuss50
approved these changes
Jun 27, 2025
modmuss50
added
the
status: merge me please
Member
|
Note to self: needs cherry picking into .5, .6 and .7 |
modmuss50
pushed a commit
that referenced
this pull request
Jun 27, 2025
Fixes a bug introduced in #4703. The advancement's path is already modified by the getRecipeIdentifier call in each recipe JSON builder mixin, so this applied getRecipeIdentifier twice to a single ID (and to different parts). For example, this getRecipeIdentifier implementation: return super.getRecipeIdentifier(identifier).withPrefixedPath("foo/"); would have resulted in an advancement being placed at data/mod_id/advancements/foo/recipes/.../foo/the_item.json, which is clearly wrong. With this fix, only the last "foo/" will appear. (cherry picked from commit 55e55d2)
modmuss50
pushed a commit
that referenced
this pull request
Jun 27, 2025
Fixes a bug introduced in #4703. The advancement's path is already modified by the getRecipeIdentifier call in each recipe JSON builder mixin, so this applied getRecipeIdentifier twice to a single ID (and to different parts). For example, this getRecipeIdentifier implementation: return super.getRecipeIdentifier(identifier).withPrefixedPath("foo/"); would have resulted in an advancement being placed at data/mod_id/advancements/foo/recipes/.../foo/the_item.json, which is clearly wrong. With this fix, only the last "foo/" will appear. (cherry picked from commit 55e55d2) (cherry picked from commit a0fab30)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug introduced in #4703.
The advancement's path is already modified by the getRecipeIdentifier call in each recipe JSON builder mixin, so this applied getRecipeIdentifier twice to a single ID (and to different parts).
For example, this getRecipeIdentifier implementation:
would have resulted in an advancement being placed at
data/mod_id/advancement/foo/recipes/.../foo/the_item.json, which is clearly wrong. With this fix, only the last "foo/" will appear.Can be backported cleanly to any version with #4703 also applied. The 1.21.1 backport is already contained in #4724.