Allow for more flexible / configurable stripping behaviour. #4829
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shnupbups
approved these changes
Aug 24, 2025
Earthcomputer
approved these changes
Aug 24, 2025
Bawnorton
reviewed
Aug 24, 2025
...ent-registries-v0/src/main/java/net/fabricmc/fabric/mixin/content/registry/AxeItemMixin.java
Outdated
Show resolved
Hide resolved
…rmer#getStrippedBlockState as nullable
Bawnorton
approved these changes
Aug 25, 2025
modmuss50
approved these changes
Aug 26, 2025
modmuss50
added
enhancement
modmuss50
pushed a commit
that referenced
this pull request
Aug 29, 2025
* More customisable StrippableBlockRegistry * Replace lambda Inject with ModifyArg, mark result of StrippingTransformer#getStrippedBlockState as nullable (cherry picked from commit c75de69)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes stripping behaviour bit more configurable, by removing the restriction of requiring AXIS property, while also allowing to define the way stripped state should be created.
Existing StrippableBlockRegistry#register(Block input, Block stripped) still only copies AXIS property.
A new StrippableBlockRegistry#registerCopyState(Block input, Block stripped) makes it copy all compatible properties.
If someone needs bit more control, they can use StrippableBlockRegistry#register(Block input, Block stripped, StrippingTransformer transformer) to define how and what is copied.