Visually losslessly optimize compression of PNG resources #4989
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
using oxipng 9.1.5 with `-Z -o max --fast --nc -a`
LambdAurora
added
priority: low
modmuss50
approved these changes
Nov 14, 2025
Member
modmuss50
left a comment
modmuss50
left a comment
There was a problem hiding this comment.
Sure, why not. Thanks for testing.
modmuss50
added
the
status: merge me please
Contributor
Author
|
I also tested it with the new Mod Menu on 25w45a now and it seems fine |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See FabricMC/fabric-loader#1071. Essentially a new attempt at #884.
Using oxipng 9.1.5 with
-Z -o max --fast --nc -a. Shrinks the repo by 29,432 B and the built jar by 1,368 B (before and after built locally).Testing
The game runs as expected with no obvious issues.
There is no Mod Menu version for 25w45a, but I also can't seem to build any branch other than 1.21.11 of Fabric API my system. I instead extracted the 0.138.0+1.21.10 version from Modrinth and all contained jars at
/META-INF/jars/, ran the same command as above on everything and reconstructed the jar. The first of the images below is taken with the modified jar.Visually comparing all of the images in GitHub's diff viewer I also noticed no differences.
I had to remove lines 58-74 in
fabric-registry-sync-v0/src/main/java/net/fabricmc/fabric/api/event/registry/DynamicRegistries.javaand increase Gradle's Xmx to getgradlew buildto succeed on the 1.21.11 branch, since the.javadoctask would otherwise fail withor Gradle would run out of heap space.
gradlew checksucceeds (ran before the aforementioned change) and produces problems-report.html.