Early 1.21.11 FRAPI fixes #4995
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Allow SpriteGetter.spriteFinder() to return the item atlas' sprite finder - Fix SpriteGetter.spriteFinder() accepting definition ID instead of texture ID - Fix RenderLayerHelper.getEntityBlockLayer() and ItemRenderContext.getVertexConsumer() using the wrong translucent layer
PepperCode1
added
bug
modmuss50
approved these changes
Nov 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SpriteGetter.spriteFinder()to return the item atlas' sprite finderSpriteGetter.spriteFinder()accepting definition ID instead of texture IDRenderLayerHelper.getEntityBlockLayer()andItemRenderContext.getVertexConsumer()using the wrong translucent layerSomewhat significant design changes are still necessary to accommodate the item atlas in FRAPI, but the fixes in this PR at least fix scenarios that work correctly in vanilla but not with FRAPI/Indigo.