Skip to content

Remove Amazon Linux 2 Dockerfile and update build workflow to exclude it#34

Merged
dudizimber merged 1 commit intomainfrom
add-rhel9-image
Dec 23, 2025
Merged

Remove Amazon Linux 2 Dockerfile and update build workflow to exclude it#34
dudizimber merged 1 commit intomainfrom
add-rhel9-image

Conversation

@dudizimber
Copy link
Copy Markdown
Contributor

@dudizimber dudizimber commented Dec 23, 2025

PR Summary by Typo

Overview

This PR removes support for Amazon Linux 2 by deleting its Dockerfile and updating the build workflow to exclude it from future builds.

Key Changes

  • Removed the Dockerfile.amazonlinux2 file.
  • Updated the build-docker-image.yml GitHub Actions workflow to no longer include amazonlinux2 in the build matrix.

Work Breakdown

Category Lines Changed
Churn 78 (100.0%)
Total Changes 78
To turn off PR summary, please visit Notification settings.

Summary by CodeRabbit

  • Chores
    • Discontinued Docker image builds for Amazon Linux 2 by removing the distribution from the build matrix. The change eliminates the associated build configuration and development environment setup previously required for this platform, streamlining the Docker image generation process and reducing build infrastructure maintenance overhead.

✏️ Tip: You can customize this high-level summary in your review settings.

@typo-app
Copy link
Copy Markdown
Contributor

typo-app bot commented Dec 23, 2025

Static Code Review 📊

✅ All quality checks passed!

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Dec 23, 2025

Walkthrough

Removed Amazon Linux 2 support from the Docker build pipeline. The workflow matrix no longer includes the amazonlinux2 entry, and the corresponding Dockerfile.amazonlinux2 file was deleted entirely.

Changes

Cohort / File(s) Summary
Amazon Linux 2 Support Removal
.github/workflows/build-docker-image.yml, Dockerfile.amazonlinux2
Removed amazonlinux2 from the OS matrix in the build workflow. Deleted the entire Dockerfile.amazonlinux2 file that previously defined a multi-stage build with yum-based toolchain setup, including cmake, GNU make, and PEG installations.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main changes: removal of Amazon Linux 2 Dockerfile and exclusion from the build workflow.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch add-rhel9-image

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@typo-app typo-app bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AI Code Review 🤖

Files Reviewed: 2
Comments Added: 0
Lines of Code Analyzed: 78
Critical Issues: 0

PR Health: Excellent 🔥

Give 👍 or 👎 on each review comment to help us improve.

@dudizimber dudizimber merged commit 0520a79 into main Dec 23, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants