clean deny errors

[gkorland]

Summary by CodeRabbit

• Chores
  • Updated configuration to expand the list of exceptions for certain platform and system-specific components. This change does not impact user-facing features or functionality.

[coderabbitai]

Walkthrough

The deny.toml configuration file was updated to expand the skip list under the [bans] section. This change adds numerous platform-specific crates and targets, particularly for macOS and various Windows architectures, to the list of exceptions for the multiple-versions ban. No other sections or logic were modified.

Changes

File	Change Summary
deny.toml	Expanded the [bans] skip list with additional macOS and Windows-related crates and targets.

Poem

In the garden of configs, a list grew wide,
With macOS and Windows crates tucked inside.
Exceptions expanded, the skip list anew,
Ban enforcement softened for platforms in view.
A hop, a skip, across OSes we tread—
The rabbit keeps hopping, with fewer bans to dread! 🐇

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

deny.toml (1)

9-19: Group and alphabetize skip entries for maintainability.

The expanded skip list is correct, but its length and lack of structure make future updates error-prone. Consider:

• Splitting entries into logical blocks (e.g., macOS crates, general crates, Windows crates, Windows targets).
• Sorting each block alphabetically.
• If cargo-deny supports glob patterns (e.g., "windows_*"), use a single pattern for all Windows targets to reduce duplication.

Example diff:

 skip = [
+  # macOS system crates
+  "core-foundation",
+  "security-framework",
+
+  # General crates
+  "getrandom",
+  "wasi",
+
+  # Windows crates
+  "windows-sys",
+  "windows-targets",
+
+  # Windows target profiles
+  "windows_aarch64_gnullvm",
+  "windows_aarch64_msvc",
+  "windows_i686_gnu",
+  "windows_i686_gnullvm",
+  "windows_i686_msvc",
+  "windows_x86_64_gnu",
+  "windows_x86_64_gnullvm",
+  "windows_x86_64_msvc",
 ]

Verify that each skip entry corresponds to an actual crate or target in your Cargo.lock. You can run:

#!/bin/bash
# Check that skip entries exist in Cargo.lock
entries=(
  wasi getrandom windows-sys core-foundation security-framework windows-targets
  windows_aarch64_gnullvm windows_aarch64_msvc windows_i686_gnu
  windows_i686_gnullvm windows_i686_msvc windows_x86_64_gnu
  windows_x86_64_gnullvm windows_x86_64_msvc
)
for e in "${entries[@]}"; do
  if ! rg -q "\"$e\"" Cargo.lock; then
    echo "Warning: skip entry '$e' not found in Cargo.lock"
  fi
done

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ba39a2c and 3746d52.

⛔ Files ignored due to path filters (1)

• Cargo.lock is excluded by !**/*.lock

📒 Files selected for processing (1)

• deny.toml (1 hunks)

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.39%. Comparing base (ba39a2c) to head (3746d52).
Report is 2 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #110   +/-   ##
=======================================
  Coverage   85.39%   85.39%           
=======================================
  Files          28       28           
  Lines        3937     3937           
  Branches     3937     3937           
=======================================
  Hits         3362     3362           
  Misses        385      385           
  Partials      190      190           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.