-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
fix NPE for unknown fields #2297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ObjectMapper mapper = JsonMapper.builder().addHandler(new DeserializationProblemHandler(){ | ||
@Override | ||
public boolean handleUnknownProperty(DeserializationContext ctxt, JsonParser p, JsonDeserializer<?> deserializer, Object beanOrClass, String propertyName) throws IOException { | ||
p.readValueAsTree(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NPE is here without changes in BeanDeserializerBase
Thank you very much for reporting this and submitting the fix (plus tests which is the best part)! Only one process thing before I can merge this in: if we haven't yet asked, we need CLA before the first contribution, from:
and usually the easiest way is to print, fill & sign, scan, email to Thank you once again for the contribution. |
Hi Talu!
Thanks for quick answer!
I signed docs and attached it to this email:)
вт, 9 апр. 2019 г. в 14:07, Tatu Saloranta <[email protected]>:
… Thank you very much for reporting this and submitting the fix (plus tests
which is the best part)!
Only one process thing before I can merge this in: if we haven't yet
asked, we need CLA before the first contribution, from:
https://github.com/FasterXML/jackson/blob/master/contributor-agreement.pdf
and usually the easiest way is to print, fill & sign, scan, email to info
at fasterxml dot com.
It's a one-time thing and valid for all Jackson projects.
If you could get this done, I'll merge this ASAP.
Thank you once again for the contribution.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#2297 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACw7pWZPYfJmmIlQUyqfjSRBN9prOnFrks5vfQEqgaJpZM4clZcF>
.
--
Best regards,
Polina Vlasenko
e-mail: [email protected]
phone.: +1-650-431-5441
|
Read your message one more time and sent it to [email protected] :) |
Excellent! Github unfortunately doesn't do attachment very well. It would be nice to have more automated way to deal with CLAs but so far this has been sufficient to keep IP lawyers off our back so that's good. :) |
Thank you again -- this exposed a few other similar places, where |
No description provided.