Don't ship pam.py in the module #49
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure it makes any sense to include the file at all any more, but this is more conservative than just dropping it, I guess. Having it in the module itself just feels like a footgun. It means you can try to do |
The comment at the top of this file says: "This is a legacy file, it is not used. Here for example." so it seems sensible to no longer ship it as part of the pam module itself. This moves it to an examples/ directory which will not be included in builds of the actual module, and updates the comment. Signed-off-by: Adam Williamson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The comment at the top of this file says:
"This is a legacy file, it is not used. Here for example." so it seems sensible to no longer ship it as part of the pam module itself. This moves it to an examples/ directory which will not be included in builds of the actual module, and updates the comment.