Bugfix/redis connection is closed #3591
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
November 24, 2024 16:32
…connections are opened and closed per operation.
HenryHengZJ
approved these changes
Dec 1, 2024
Contributor
HenryHengZJ
left a comment
HenryHengZJ
left a comment
There was a problem hiding this comment.
thank you @xmaiconx !
Yshayy
pushed a commit
to Yshayy/Flowise
that referenced
this pull request
Apr 23, 2025
* Added redis open connection if it is closed * Removed unecessary modification * Added check connection in all methods * Renamed method * added await on method call * Refactor Redis connection handling: remove singleton pattern, ensure connections are opened and closed per operation. --------- Co-authored-by: Maicon Matsubara <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored Redis Connection Management
This pull request refactors the Redis connection handling to remove the singleton pattern, which previously restricted the application to a single Redis client configuration. By opening and closing connections per operation, we ensure that multiple Redis clients can be configured and used independently within the application. This change improves flexibility and aligns with best practices for managing database connections.