Skip to content

GCNConv layer supports FeaturedGraph #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 11, 2020
Merged

GCNConv layer supports FeaturedGraph #34

merged 5 commits into from
Apr 11, 2020

Conversation

yuehhua
Copy link
Member

@yuehhua yuehhua commented Apr 11, 2020

No description provided.

@yuehhua yuehhua mentioned this pull request Apr 11, 2020
Closed
@yuehhua yuehhua merged commit f49858c into master Apr 11, 2020
@yuehhua yuehhua deleted the develop branch April 11, 2020 14:20
@rkurchin
Copy link

Thanks!! Small bug with this, the Base.show definition needs to be fixed because it still tries to print something involving l.norm which no longer exists and causes the constructor to error out.

(sorry if this is the wrong place to point this out)

@rkurchin
Copy link

Also, it would be good if GCNConv(FeaturedGraph) returned another FeaturedGraph so they could easily be strung together. Or if there were an option for this at least, since obviously the one at the end of the chain would ideally return just the matrix.

@rkurchin rkurchin mentioned this pull request Apr 20, 2020
Closed
yuehhua referenced this pull request Jun 19, 2020
@yuehhua
Upgrade to v0.5.1
ca693cb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yuehhua @rkurchin