Upgrade to inline-style-prefixer v3 #945

exogen · 2017-11-29T03:59:43Z

This upgrades inline-style-prefixer to version 3. Fixes #918.

There is one failing test due to Prefixed properties should precede their unprefixed equivalents robinweser/inline-style-prefixer#147. If inline-style-prefixer does not incorporate this change eventually, we'll have to adjust its output ourselves. Thoughts?
Because inline-style-prefixer's default browser support has changed, and (per @alexlande) Radium roughly targets React's browser support, we now create a custom Prefixer for use with the prefixer plugin. The new Prefixer matches inline-style-prefixer v2's browser support, so people should be able to upgrade without breaking anything.
The browser data for the new Prefixer is generated by the new update-prefix-data script and stored in src/prefix-data (the script outputs ES source files).
New Flow interfaces were added for the new inline-style-prefixer modules we use.

exogen · 2017-11-29T04:02:08Z

.eslintrc

@@ -176,7 +176,8 @@ rules:

    brace-style:                   # enforce one true brace style
        [2, "1tbs", { "allowSingleLine": true }]
-    camelcase: 2                   # require camel case names
+    camelcase:                     # require camel case names, except in properties
+        [2, { "properties": "never" }]


inline-style-prefixer's browser data generator outputs objects with keys like ios_saf. This disables the camelcase check for object properties. We can't easily add eslint-disable rules to those specific files because they're generated.

Which files are generated?

src/prefix-data/static.js and src/prefix-data/dynamic.js

Is there anything else in prefix-data? If not, can't we just revert this here and drop a new src/prefix-data/.eslintrc that overrides it there?

I considered that and would be happy to do it, lemme make the case for why I didn't though:

We'd need it in scripts too (the input object to generateData also has underscores)

Really I find the whole lint rule applying to properties extremely presumptuous. Other people's APIs use underscores (this example, JSON from REST APIs, even React has unstable_foo methods that people actually use) and it's lame needing an exception for that every single time. If our code were completely self-contained and didn't interact with anyone else's APIs then it would make sense.

coveralls · 2017-11-29T04:03:34Z

Coverage increased (+0.3%) to 94.32% when pulling 5a2ba31 on chore/inline-style-prefixer-v3 into baa0ccc on master.

coveralls · 2017-11-29T04:03:34Z

Coverage increased (+0.3%) to 94.32% when pulling 5a2ba31 on chore/inline-style-prefixer-v3 into baa0ccc on master.

coveralls · 2017-11-29T04:03:34Z

Coverage increased (+0.3%) to 94.32% when pulling 5a2ba31 on chore/inline-style-prefixer-v3 into baa0ccc on master.

ryan-roemer · 2017-11-29T17:31:58Z

scripts/update-prefix-data.js

+ * this if browser support changes or `inline-style-prefixer` gets fixes for the
+ * supported browsers.
+ */
+import path from 'path'


We need to lint the scripts.

Done. I changed ESLint to lint everything so this forgotten-directories thing stops happening (turns out test was also not linted).

coveralls · 2017-11-29T17:54:23Z

Coverage increased (+0.3%) to 94.32% when pulling 647e898 on chore/inline-style-prefixer-v3 into baa0ccc on master.

coveralls · 2017-11-29T17:54:23Z

Coverage increased (+0.3%) to 94.32% when pulling 647e898 on chore/inline-style-prefixer-v3 into baa0ccc on master.

coveralls · 2017-11-29T17:54:23Z

Coverage increased (+0.3%) to 94.32% when pulling 647e898 on chore/inline-style-prefixer-v3 into baa0ccc on master.

ryan-roemer · 2017-12-29T15:01:30Z

@exogen -- Looks like https://unpkg.com/[email protected]/ is released!

Do we just version bump to finish this PR or does other work remain?

/cc @alexlande

ryan-roemer · 2017-12-29T15:02:25Z

test/enhancer-test.js

-  expect(rendered)
-    .to.contain('data-radium="true"').and
-    .to.contain('style="background:red;color:white"');
+  expect(rendered).to


Is this an auto-formatted result? Chai assertions are typically always:

expect(foo) .to.SOMETHING.and .to.SOMETHING_ELSE.and .to.LAST_THING;

Or is that prettier turned loose?

looks like that is what prettier wants. npm run lint will fail otherwise.

stefvhuynh · 2018-01-02T19:19:35Z

looks like [email protected] has been released. according to the changelog (https://github.com/rofrischmann/inline-style-prefixer/blob/master/Changelog.md), the only changes are @exogen's PR and updated browser versions. seems like no other work needs to be done here?

ryan-roemer · 2018-01-02T19:20:18Z

@stefvhuynh -- Give the update a go and see if you can get CI to pass!

coveralls · 2018-01-02T19:23:47Z

Coverage increased (+0.3%) to 94.32% when pulling 12ddeb7 on chore/inline-style-prefixer-v3 into baa0ccc on master.

coveralls · 2018-01-02T19:23:48Z

Coverage increased (+0.3%) to 94.32% when pulling 12ddeb7 on chore/inline-style-prefixer-v3 into baa0ccc on master.

coveralls · 2018-01-02T19:23:48Z

Coverage increased (+0.3%) to 94.32% when pulling 12ddeb7 on chore/inline-style-prefixer-v3 into baa0ccc on master.

coveralls · 2018-01-02T19:30:31Z

Coverage increased (+0.3%) to 94.32% when pulling cf6a094 on chore/inline-style-prefixer-v3 into baa0ccc on master.

alexlande

Looks good to me! 👍

ryan-roemer · 2018-01-04T12:58:39Z

@alexlande -- Thanks!

@stefvhuynh -- You're a go for merge + publish!

ryan-roemer · 2018-01-04T12:59:31Z

@stefvhuynh @alexlande @exogen -- What semver bump is this change?

exogen · 2018-01-04T16:58:47Z

@ryan-roemer Big dependency bumps like this are tricky – the intention here was to be MINOR (we tried to make sure to support the same browser versions as before, none of our tests had to change, we get some new i-s-p features). But then again i-s-p v3 was also a complete rewrite, it wouldn't surprise me if some edge cases were different for some people, so MAJOR would be the absolute safest.

alexlande · 2018-01-04T17:00:26Z

Given that Radium is still on 0.x releases I think it would make sense to make this 0.20.0

Upgrade to inline-style-prefixer v3

5a2ba31

exogen commented Nov 29, 2017

View reviewed changes

ryan-roemer reviewed Nov 29, 2017

View reviewed changes

Apply lint to all directories.

647e898

ryan-roemer reviewed Dec 29, 2017

View reviewed changes

Update inline-style-prefixer to v4

12ddeb7

Update prefix data

cf6a094

alexlande approved these changes Jan 2, 2018

View reviewed changes

ryan-roemer changed the title ~~wip: Upgrade to inline-style-prefixer v3~~ Upgrade to inline-style-prefixer v3 Jan 4, 2018

stefvhuynh merged commit eecaa77 into master Jan 8, 2018

stefvhuynh deleted the chore/inline-style-prefixer-v3 branch January 8, 2018 20:45

opichals mentioned this pull request Jun 5, 2018

fix(css): upgrade radium to v0.24.1 apiaryio/attributes-kit#463

Merged

Upgrade to inline-style-prefixer v3 #945

Upgrade to inline-style-prefixer v3 #945

Uh oh!

Conversation

exogen commented Nov 29, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ryan-roemer Nov 29, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

coveralls commented Nov 29, 2017

Uh oh!

coveralls commented Nov 29, 2017

Uh oh!

coveralls commented Nov 29, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

coveralls commented Nov 29, 2017

Uh oh!

coveralls commented Nov 29, 2017

Uh oh!

coveralls commented Nov 29, 2017

Uh oh!

ryan-roemer commented Dec 29, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

stefvhuynh commented Jan 2, 2018

Uh oh!

ryan-roemer commented Jan 2, 2018

Uh oh!

coveralls commented Jan 2, 2018

Uh oh!

coveralls commented Jan 2, 2018

Uh oh!

coveralls commented Jan 2, 2018

Uh oh!

coveralls commented Jan 2, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alexlande left a comment

Choose a reason for hiding this comment

Uh oh!

ryan-roemer commented Jan 4, 2018

Uh oh!

ryan-roemer commented Jan 4, 2018

Uh oh!

exogen commented Jan 4, 2018

Uh oh!

alexlande commented Jan 4, 2018

Uh oh!

Uh oh!

ryan-roemer Nov 29, 2017 •

edited

Loading

coveralls commented Jan 2, 2018 •

edited

Loading