Crash on Android : dataIntent must not be null

[shinekumar]

Thanks for the great component. It is working perfectly on iOS. But on Android, I am getting a crash.
I have given details below. Please let me know if you need additional details. Thanks!

Device Info
Samsung Galaxy S5
OS: 6.0.1

Package Info
"react-native-app-auth": "^2.6.0",

Issue

• Login Page Loads
• Enters Username and Password. Press Login
• App Crashes

Log

java.lang.RuntimeException: Failure delivering result ResultInfo{who=null, request=0, result=0, data=null} to activity {com.realsavvyv3/com.realsavvyv3.MainActivity-Main}: java.lang.NullPointerException: dataIntent must not be null
at android.app.ActivityThread.deliverResults(ActivityThread.java:4920)
at android.app.ActivityThread.handleSendResult(ActivityThread.java:4963)
at android.app.ActivityThread.access$1600(ActivityThread.java:221)
at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1848)
at android.os.Handler.dispatchMessage(Handler.java:102)
at android.os.Looper.loop(Looper.java:158)
at android.app.ActivityThread.main(ActivityThread.java:7224)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:1230)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1120)
Caused by: java.lang.NullPointerException: dataIntent must not be null
at net.openid.appauth.Preconditions.checkNotNull(Preconditions.java:55)
at net.openid.appauth.AuthorizationResponse.fromIntent(AuthorizationResponse.java:565)
at com.reactlibrary.RNAppAuthModule.onActivityResult(RNAppAuthModule.java:213)
at com.facebook.react.bridge.ReactContext.onActivityResult(ReactContext.java:255)
at com.facebook.react.ReactInstanceManager.onActivityResult(ReactInstanceManager.java:730)
at com.facebook.react.ReactActivityDelegate.onActivityResult(ReactActivityDelegate.java:126)
at com.facebook.react.ReactActivity.onActivityResult(ReactActivity.java:77)
at android.app.Activity.dispatchActivityResult(Activity.java:7137)
at android.app.ActivityThread.deliverResults(ActivityThread.java:4916)
at android.app.ActivityThread.handleSendResult(ActivityThread.java:4963) 
at android.app.ActivityThread.access$1600(ActivityThread.java:221) 
at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1848) 
at android.os.Handler.dispatchMessage(Handler.java:102) 
at android.os.Looper.loop(Looper.java:158) 
at android.app.ActivityThread.main(ActivityThread.java:7224) 
at java.lang.reflect.Method.invoke(Native Method)

[thestillheron]

I'm also experiencing this issue. Can I ask what kind of authorization server you're trying to integrate with?

I'm having exactly this issue while trying to integrate with Azure Active Directory B2C.

[shinekumar]

@finalgriever I don't think it has anything to do with the server. It is purely an issue with the module. Right now I am using browser for Android as it is still crashing.

[thestillheron]

I've continued my work on diagnosing this issue, and I've started to realise that this exact error message can occur on any number of problems.

In my case, I've been able to reproduce this error message by creating the following invalid states:

• Attempting to use a redirectUrl that has not been whitelisted on the auth server
• Not having my application listen on the given redirectUrl
• Not having my auth server be correctly listed with my social identity provider

Basically, this error message seems to be provoked by any failure in any part of the communication between the auth server, and the client. Which makes troubleshooting any problem in that area a bit of a nightmare.

I've since managed to resolve my issues, and now I'm getting "Failed exchange token". Good times :P

[kadikraman]

I appreciate it's a nightmare to debug. More informative error messaging is certainly on the roadmap. Are you using a mainstream auth provider or is it in house? Is there any way I could reproduce the error?

[jeff-halhead]

Hi @finalgriever did you find a solution? I'm getting the same "Failed exchance token" error message when trying to integrate with with B2C.

[shinekumar]

@kadikraman it is an in-house server. I don't know a way to recreate it. If you guide me through some steps to troubleshoot, I am happy to help

[thestillheron]

Sorry @jeff-halhead, I can't remember exactly what I did to resolve that issue.
There were a few problems that I had which I recall having to use the following fixes for:

• I had to specify the authorization and token endpoints explicitly with the service configuration property
• I had been setting up my intent filters wrong, so my app wasn't correctly listening for the callback
• I had been providing the policy get parameter (the p parameter) in the "additionalParameters" parameter. Instead, I should have been hard coding it into the urls provided for the auth and token endpoints.

[jeff-halhead]

@finalgriever Thanks for getting back to me. I also had a few problems with my configuration and now it is working. I was able to solve them by debugging RNAppAuthModule and looking at the exceptions that were happening.

For anyone else who is struggling, this is the config I used that is working for me. It is different from the Azure AD one in the main README file.

export const b2cConfig = {
    issuer: 'https://login.microsoftonline.com/<tenant name>/v2.0?p=<sign in/up policy name>',
    clientId: '<client id>',
    redirectUrl: '<appAuthRedirectScheme from build.gradle>://oauth2/redirect',
    scopes: [
        'openid',
        'offline_access',
        '<client id>',
    ],
    additionalParameters: {},
};

[kadikraman]

Interesting @jeff-halhead so the differences I see are

1. appending /v2.0?p=<sign in/up policy name> to your issuer
2. adding client id to scopes

Adding the client id to scopes seems very strange, is that definitely needed?

As for editing the url parameter, you can replace that with

additionalParameters: {
  p: <sign in/up policy name>
}

Which is equivalent.

[jeff-halhead]

@kadikraman adding the client id to scopes was actually not required. Please disregard that change.

I tried adding the sign in policy to additionalParameters but it does not work in my case.

[duro]

@kadikraman As I mentioned in closed ticket #101 we are experiencing this same crash when authing against Uber.

If you have any tips to nudge us in the right direction, we have some Java resources over here that can help do a deeper diagnosis.

Here is the stacktrace from the most recent crash:

# Crashlytics - plaintext stacktrace downloaded
# Platform: android
# OS Version: 8.0.0
# Device: SM-G950U1

#0. Crashed: main
       at android.app.ActivityThread.deliverResults(ActivityThread.java:4489)
       at android.app.ActivityThread.handleSendResult(ActivityThread.java:4532)
       at android.app.ActivityThread.-wrap20(Unknown Source)
       at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1752)
       at android.os.Handler.dispatchMessage(Handler.java:105)
       at android.os.Looper.loop(Looper.java:164)
       at android.app.ActivityThread.main(ActivityThread.java:6938)
       at java.lang.reflect.Method.invoke(Method.java)
       at com.android.internal.os.Zygote$MethodAndArgsCaller.run(Zygote.java:327)
       at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1374)

--

Fatal Exception: java.lang.RuntimeException: Failure delivering result ResultInfo{who=null, request=0, result=0, data=null} to activity {com.freebirdrides.android/com.freebirdrides.android.MainActivity}: java.lang.RuntimeException: java.lang.NullPointerException: dataIntent must not be null
       at android.app.ActivityThread.deliverResults(ActivityThread.java:4489)
       at android.app.ActivityThread.handleSendResult(ActivityThread.java:4532)
       at android.app.ActivityThread.-wrap20(Unknown Source)
       at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1752)
       at android.os.Handler.dispatchMessage(Handler.java:105)
       at android.os.Looper.loop(Looper.java:164)
       at android.app.ActivityThread.main(ActivityThread.java:6938)
       at java.lang.reflect.Method.invoke(Method.java)
       at com.android.internal.os.Zygote$MethodAndArgsCaller.run(Zygote.java:327)
       at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1374)

Caused by java.lang.RuntimeException: java.lang.NullPointerException: dataIntent must not be null
       at com.facebook.react.bridge.ReactContext.handleException(ReactContext.java:311)
       at com.facebook.react.bridge.ReactContext.onActivityResult(ReactContext.java:255)
       at com.facebook.react.ReactInstanceManager.onActivityResult(ReactInstanceManager.java:692)
       at com.facebook.react.ReactActivityDelegate.onActivityResult(ReactActivityDelegate.java:126)
       at com.facebook.react.ReactActivity.onActivityResult(ReactActivity.java:75)
       at com.freebirdrides.android.MainActivity.onActivityResult(MainActivity.java:13)
       at android.app.Activity.dispatchActivityResult(Activity.java:7548)
       at android.app.ActivityThread.deliverResults(ActivityThread.java:4485)
       at android.app.ActivityThread.handleSendResult(ActivityThread.java:4532)
       at android.app.ActivityThread.-wrap20(Unknown Source)
       at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1752)
       at android.os.Handler.dispatchMessage(Handler.java:105)
       at android.os.Looper.loop(Looper.java:164)
       at android.app.ActivityThread.main(ActivityThread.java:6938)
       at java.lang.reflect.Method.invoke(Method.java)
       at com.android.internal.os.Zygote$MethodAndArgsCaller.run(Zygote.java:327)
       at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1374)

Caused by java.lang.NullPointerException: dataIntent must not be null
       at net.openid.appauth.Preconditions.checkNotNull(Preconditions.java:55)
       at net.openid.appauth.AuthorizationResponse.fromIntent(AuthorizationResponse.java:565)
       at com.reactlibrary.RNAppAuthModule.onActivityResult(RNAppAuthModule.java:210)
       at com.facebook.react.bridge.ReactContext.onActivityResult(ReactContext.java:253)
       at com.facebook.react.ReactInstanceManager.onActivityResult(ReactInstanceManager.java:692)
       at com.facebook.react.ReactActivityDelegate.onActivityResult(ReactActivityDelegate.java:126)
       at com.facebook.react.ReactActivity.onActivityResult(ReactActivity.java:75)
       at com.freebirdrides.android.MainActivity.onActivityResult(MainActivity.java:13)
       at android.app.Activity.dispatchActivityResult(Activity.java:7548)
       at android.app.ActivityThread.deliverResults(ActivityThread.java:4485)
       at android.app.ActivityThread.handleSendResult(ActivityThread.java:4532)
       at android.app.ActivityThread.-wrap20(Unknown Source)
       at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1752)
       at android.os.Handler.dispatchMessage(Handler.java:105)
       at android.os.Looper.loop(Looper.java:164)
       at android.app.ActivityThread.main(ActivityThread.java:6938)
       at java.lang.reflect.Method.invoke(Method.java)
       at com.android.internal.os.Zygote$MethodAndArgsCaller.run(Zygote.java:327)
       at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1374)

[kadikraman]

@duro I'm confident it's not the same issue as the one you've linked to. The problem there was that the startActivityForResult API we used was not supported on older Android phones. However you've said your error is happening on newer versions.

Have you managed to reproduce it locally on an emulator or has it just been in logs?

[duro]

@kadikraman This has only been in Crashlytics / Play Store logs. We have tried repeatedly to reproduce locally, but to no avail. However, the crash volume in Crashlytics / Play Store is considerable. We have been getting 10-20 a day.

[kadikraman]

@duro this is going to be a blast to debug 😄

You've probably already figured this out, but the error is happening here which is when the user has authenticated in the browser, and we're deep linking back to the app. The Intent being passed in is null so the actual error being thrown is here in the AppAuth-Android library we're bridging.

I don't really know what's causing this, it could be

1. device specific
2. service provider specific
3. user spesific
4. combination of ^^
5. ??? something we haven't thought of yet

It would be ideal if we could reproduce the error locally. Do you have any more stats on your logs? Exactly which devices on which version of Android?

[duro]

@kadikraman Here is the info that Crashlytics gives us on this: