fix: guard null promise in case of skipCodeExchange #595
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
we have been having this issue happen as well, #427 this was my previous fix, but looks like this one had been missed. |
Shervanator
approved these changes
Jan 12, 2021
|
@kadikraman any chance we can get this one in :) |
kadikraman
approved these changes
Jan 14, 2021
|
Thank you so much for the PR! This is now released in v6.0.2 🚀 |
|
out of interest @FallenDestiny do we understand why the promise can sometimes be null? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #594
Description
Add a guard before using promise in case it's null when
skipCodeExchangeistrue