Custom Nonce passing as an additional parameter is not properly configured #736
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kadikraman
reviewed
Jun 8, 2022
kadikraman
reviewed
Jun 9, 2022
Remove the nonce from the additional parameters once it's added to the authRequestBuilder
kadikraman
approved these changes
Jun 12, 2022
|
This is published in the next release candidate 7.0.0-rc1 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The nonce is not setup correctly once it's passed from JS to the native side as an additional parameter , resulting in a nonce comparison error.
When the nonce is passed as a parameter in the additional parameters section , and setting UseNonce to true , the native side does not take in consideration those changes and keeps the randomly generated nonce instead for comparison.
This PR helps checking if there is a nonce being passed in the additional parameters section and changes it if there is.