solve the “undefined variables ‘context’” problem #1853
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1839
There does appear to be a real issue here, likely caused by a minor mistake during development. In the
ActionNode.fill
method, the parameter is incorrectly namedreq
, while intemplate/operator.py
, the_fill_node
function explicitly passes an argument namedcontext
, leading to a parameter mismatch.Here is a minimal reproduction of the inconsistency:
Since the
ActionNode
class consistently usescontext
as the field name, changing the parameter name infill
fromreq
tocontext
should resolve the issue.In addition, I noticed that during dataset evaluation via
benchmark.run_evaluation
, up to 50 asynchronous tasks may run concurrently. When using LLMs that produce streaming output, this results in interleaved outputs from different tasks being printed to the terminal, making logs difficult to read and debug.It might be more helpful to either:
This would make evaluation logs much more manageable.
Lastly, I’ve encountered a few other small issues during usage. It also seems that the project hasn’t seen recent updates or bug fixes, which makes me wonder if it’s still actively maintained. That would be unfortunate, as this is a valuable and meaningful project with great potential.
If needed, I’d be happy to contribute fixes via pull requests. Thank you for the great work so far!