Skip to content

FreeRTOS.h configSTACK_DEPTH_TYPE inconsistent with default type #986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
feilipu opened this issue Feb 7, 2024 · 1 comment
Closed

FreeRTOS.h configSTACK_DEPTH_TYPE inconsistent with default type #986

feilipu opened this issue Feb 7, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@feilipu
Copy link
Contributor

feilipu commented Feb 7, 2024 •
edited
Loading

Description
In #942 the default configuration value was inadvertently left set as uint16_t in FreeRTOS.h. Later updates to the merged PR omitted to update the configuration default to StackType_t.

It should be updated to StackType_t, to match the rest of the already merged PR #942.

Targets
All targets use FreeRTOS.h, where the default is incorrect.

Additional context
Some targets need to use the added default definition in portable.h from #942 to build, as they don't include FreeRTOS.h before using the definition. I think that this is probably bad, and is probably bugged too.

The duplicate default in portable.h should be removed, when the ports are repaired.
@feilipu feilipu added the bug Something isn't working label Feb 7, 2024
@kar-rahul-aws kar-rahul-aws mentioned this issue Feb 8, 2024
Merged
2 tasks
@kar-rahul-aws
Copy link
Member

Hi @feilipu
Thanks for pointing the issue. We have merged the PR #987 with the necessary changes . We will look into the port issues you mentioned and address it in a later PR, if required.

laroche pushed a commit to laroche/FreeRTOS-Kernel that referenced this issue Apr 18, 2024
@kar-rahul-aws
Set configMAX_SYSCALL_INTERRUPT_PRIORITY to 4 for QEMU demos (FreeRTO…
03db1e8 
…S#986)

* Update FreeRTOSConfig.h

* Update FreeRTOSConfig.h

* Update FreeRTOSConfig.h
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@feilipu @kar-rahul-aws