Check for add overflow only once #467
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the size calculations such that we only need to check for add overflow only once. Also, change the way we detect add overflow so that we do not need to cause an overflow to detect an overflow. Signed-off-by: Gaurav Aggarwal <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #467 +/- ##
=======================================
Coverage 92.44% 92.44%
=======================================
Files 4 4
Lines 1270 1270
Branches 343 343
=======================================
Hits 1174 1174
Misses 50 50
Partials 46 46
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
n9wxu
approved these changes
Mar 3, 2022
cobusve
approved these changes
Mar 3, 2022
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update the size calculations such that we only need to check for add overflow only once. Also, change the way we detect add overflow so that we do not need to cause an overflow to detect an overflow.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.