-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Add support for the configUSE_TASK_FPU_SUPPORT constant in the GCC/ARM_CR5 port #584
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
b86f9b8
Add support for the configUSE_TASK_FPU_SUPPORT in the GCC/ARM_CR5 port
ChristosZosi 441c863
Adjust task stack initialitation of the GCC/ARM_CR5 port
ChristosZosi f713d01
Add support for FPU safe interrupts to the GCC/ARM_CR5 port
ChristosZosi 6f051e6
Clarify comment about the size of the FPU registers of Cortex R5
ChristosZosi f02f1e3
Minor review suggestions
aggarg File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is possible that this port is being compiled for a target without an FPU, in which case configUSE_TASK_FPU_SUPPORT may not be defined. This is probably an issue in the original Cortex-A port as well. This code as-is does not compile when configUSE_TASK_FPU_SUPPORT is left undefined or set to 0.
It might be preferable to use the configENABLE_FPU option from the ARMv8M ports and make FPU management on by default for each task rather than opt-in.
@RichardBarry and @aggarg Do you have a preference here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I see what you, @paulbartell , mean. I did take a look on the
configENABLE_FPU
option, and I strongly agree with you. Let me know, if you want theconfigENABLE_FPU
-option implemented on both ports (Cortex-R5 and A9), I would gladly do it.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should merge this PR as is and then create a separate PR which should allow setting
configUSE_TASK_FPU_SUPPORT
to 0. TheconfigUSE_TASK_FPU_SUPPORT
would then have the following meaning -0
- No FPU support.1
- Tasks individually register their intent to have a FPU context.2
- All tasks have FPU context.