Switched the documentation from Markdown to ReStructuredText #1717
Conversation
consolidate doctrine listeners and move to Doctrine directory
Version 5.0.0 of SwiftMailer has been released, which is a non-breaking change - so modifying the require-dev specification to allow <6.0.
updated swiftmailer/swiftmailer version specification
fix on resetting e-mail. subject and message were missing, there was only e-mail instead, and it didn't work
Update FOSUserBundle.sk.yml
Add badge poser
added diacritices and validation translation
Update FOSUserBundle.ro.yml and added validators.ro.yml
Typo in uk translation
Updated to new definition validation minLength, maxLength => Length
Update wrong comment
Is the format is missing InvalidArgumentException: Template name "MktUserBundle:Registration:email.twig" is not valid (format is "bundle:section:template.format.engine")
The format is required by FrameworkBundle
With this PR, globals defined variables aren't available on email twig templates.
Merge local variables with globals
Changed use of prependClientTransformer to addViewTransformer.
|
I did a very quick review (I tried to stick to formatting things only). |
|
@wouterj I've added a hidden TOC to avoid Sphinx problems (see javiereguiluz@70c20da) Is this enough to correctly build this documentation? |
|
@javiereguiluz yes. But why not using the TOC to provide the list of next articles? |
|
@wouterj there is almost no bundle using RST for its documentation so I looked at one of the few that did: JMSSecurityExtraBundle uses the trick of a hidden TOC: https://raw.githubusercontent.com/schmittjoh/JMSSecurityExtraBundle/master/Resources/doc/index.rst |
|
@javiereguiluz a TOC is just a list of files (the files that are listed in TOC), using their titles. Exactly what you are now doing by manually creating the list. In Sphinx, all files have to be part of some TOC. Since you don't always want to create a TOC, there is a |
|
@javiereguiluz can you answer about the way you suggest dealing with the 1.3.x => master merge ? |
This PR was squashed before being merged into the 2.0.x-dev branch (closes FriendsOfSymfony#1373). Discussion ---------- Added basic XML Support I'm not so sure about the namespace, if you can come up with a different (better) one, I'll change it. Commits ------- 7c220cf Added basic XML Support
Conflicts: Resources/doc/groups.md
|
@javiereguiluz I also merged #1724 which impacts the doc, thus creating a conflict with your conversion. Sorry about that. Can you reapply the change in your rST version when rebasing ? |
…ntosik) This PR was merged into the 2.0.x-dev branch. Discussion ---------- Update configuration_reference.md add use_flash_notifications Commits ------- d3a9f4e Update configuration_reference.md
This PR was merged into the 2.0.x-dev branch. Discussion ---------- Doctrine xml config Commits ------- 0d7aa04 Doctrine xml config
|
@javiereguiluz ping |
javiereguiluz
force-pushed
the
transform_md_doc_to_rest
branch
from
d964a3d to
80da258
Compare
|
Closing this PR because I was trapped in "Git hell" and I prefer to create a new and clean PR: #1739 |
|
It looks like you rebased onto master instead of rebasing onto 1.3.x |
This is one of the steps defined in the "Revamp Documentation Roadmap" defined in #1577
Moreover, this change is needed to integrate as soon as possible the FOSUserBundle documentation on symfony.com, where it'll receive a lot more exposure and, hopefully, will increase the doc contributors.