Skip to content

Add view event for better integration with other bundles #913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Add view event for better integration with other bundles #913

wants to merge 4 commits into from

Conversation

vkartaviy
Copy link

For example I need integration with FOSRestBundle but I don't want to copy-paste all code from controller action to just change rendering logic...

What do you think about adding view event?

@ghost
Copy link

ghost commented Jan 29, 2013

do we really need to have all those events? I'm not sure what would be better though :(

@vkartaviy
Copy link
Author

Those events doesn't break compatibility and gives you ability to change responses if needed.

Without view events it's not possible to change rendering logic...

@kingcrunch
Copy link

I must say this many events makes me a little nervous too: Many events tightens the coupling between this and other bundles, that makes use of the events, again. Events should be used, where an actual event happens, but if everything would trigger an event, just because it renders something, access the persistence, or something like that, it can get quite confusing.

What is the actual use case? When you say "rendering logic", isn't this just about overriding the templates?

@ghost
Copy link

ghost commented Jun 24, 2013

@vkartaviy : can you elaborate on what you want to change that can't be done by some refactoring to the controller code or overriding templates?

@XWB
Copy link
Member

XWB commented Sep 6, 2016

This is being added in other PR's.

@XWB XWB closed this Sep 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants