Experimental: index, index_assign, and nested storage vecs
#4334
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mohammadfawaz
force-pushed
the
mohammadfawaz/storage_key
branch
from
100653a to
0fa7196
Compare
mohammadfawaz
force-pushed
the
mohammadfawaz/storage_key
branch
from
26ddeee to
648b2f0
Compare
* Added `try_read()` that behaves like `read` but returns an `Option` * Changed `get` in `StorageMap` to return a `StorageHandle` instead of the value directly.
mohammadfawaz
force-pushed
the
mohammadfawaz/storage_key
branch
from
648b2f0 to
be85a10
Compare
… nested maps using both `get/insert` and the `[]` operator
mohammadfawaz
force-pushed
the
mohammadfawaz/new_storage_vec
branch
4 times, most recently
from
4aff7fc to
9dab5f8
Compare
mohammadfawaz
changed the title
StorageVec and new method get_handle to help implementing nested storage vecsindex, index_assign, and nested storage vecs
storage vecs using both `get/push` and the `[]` operator.
mohammadfawaz
force-pushed
the
mohammadfawaz/new_storage_vec
branch
from
9dab5f8 to
e3d49f7
Compare
mohammadfawaz
changed the base branch from
mohammadfawaz/storage_key
to
mohammadfawaz/nested_maps
mohammadfawaz
force-pushed
the
mohammadfawaz/nested_maps
branch
2 times, most recently
from
7bb31af to
9dfa0fb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add experimental
StorageVecusingStorageHandle.Also introduce
indexandindex_assigntoStorageVecand showcase how storage vecs and nested storage vecs could look like with and without the[]operator. These two methods should really be part of traitsIndexandIndexAssignbut we're not ready to implement those yet because we do not have associated types for traits yet.Note that
IndexAssignis inspired by rust-lang/rfcs#1129. This is probably the best we can do given that we don't want references in the language just yet (and probably ever).Checklist
Breaking*orNew Featurelabels where relevant.